feat(sig): add modifying report state via inbox#1513
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
oliverb123
force-pushed
the
sig/report-actions
branch
from
48e4461 to
2fcfa42
Compare
Twixes
force-pushed
the
graphite-base/1513
branch
from
d072d3d to
bc8fae9
Compare
This was referenced Apr 7, 2026
Twixes
force-pushed
the
sig/report-actions
branch
from
2fcfa42 to
ad2f0db
Compare
Twixes
force-pushed
the
sig/report-actions
branch
from
ad2f0db to
e7e2514
Compare
Twixes
changed the title
oliverb123
changed the base branch from
sig/component-inbox
to
graphite-base/1513
oliverb123
force-pushed
the
sig/report-actions
branch
from
e7e2514 to
efb0df6
Compare
oliverb123
force-pushed
the
graphite-base/1513
branch
from
fbc1d50 to
1735579
Compare
oliverb123
force-pushed
the
sig/report-actions
branch
from
efb0df6 to
f06467a
Compare
PascalCase file names are reserved for files exporting React components. This file only exports constants, so use kebab-case instead. Co-authored-by: Michael Matloka <dev@twixes.com>
oliverb123
force-pushed
the
sig/report-actions
branch
from
f06467a to
f32b156
Compare
This was referenced Apr 8, 2026
Twixes
approved these changes
Apr 8, 2026
Member
Twixes
left a comment
Twixes
left a comment
There was a problem hiding this comment.
A few comments from me, but as we've chatted in Slack, each I tackled in the PR stacked on top
apps/code/src/renderer/features/inbox/components/list/SignalsToolbar.tsx
Show resolved
Hide resolved
apps/code/src/renderer/features/inbox/components/list/SignalsToolbar.tsx
Show resolved
Hide resolved
Member
Twixes
added a commit
that referenced
this pull request
Apr 8, 2026
## Problem The inbox list toolbar introduced in #1513 added controls _only_ for bulk operations. But the same controls have been missing for _individual_ reports too. In the Cloud version, we had them under a dropdown in the report pane itself. I considered doing the same here, but there's no point when we have a great toolbar - the toolbar should be the individual report controls as well. At the same time, checkboxes take away from the content when shown always - and we don't need them by default for _most_ user interactions here. (Ofc will validate this, but at least I think that's a safe assumption for now that the individual report level is the primary one.) ## Changes Making the report list toolbar always-on, with intuitive logic for selection state synced with the currently-viewed-report state. Unifies the selection state, so that "currently viewed" and "selected" are the same thing. Checkboxes only show up when multiple reports are selected. For multi-select, you can use the "Select all" checkbox or standard desktop Shift/Cmd+click patterns. See in action: <img src="https://res.cloudinary.com/dmukukwp6/image/upload/Clean_Shot_2026_04_08_at_11_58_59_c89bf3657b.gif"> <!-- If you're an agent, only list tests you actually ran. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We want to be able to snooze, suppress, delete reports via the PHC inbox. We also want to be able to reingest them, although this is gated behind 1: being a staff user and 2: running a dev build.
This PR also contains some futzing with the keyboard handling, because it wasn't as good as I wanted it to be